How to fix item links for incompatible addons

[Guest] [joshmiller83]: Can we get an Astrolabe fix please? Or has WIM stopped being developed?
[DevTeam] [Astaldo]: You can disable wim2wim for now or visit the forum thread where you originally posted the issue
[DevTeam] [Zeke]: Yay for spam!
[DevTeam] [Zeke]: ....
[DevTeam] [Zeke]: I love that I get emailed when someone reports spam on the boards, but I can't do anything about it.
[DevTeam] [Nachonut]: lol i got you
[DevTeam] [Astaldo]: How about "hide email address from public checked" and it's still visible in all my posts...
[DevTeam] [Astaldo]: I'd delete my account on this site, but by the time I realized the problem half the spambots on the planet had it already
[Developer] [Pazza]: Astaldo if you log out and view your profile with a refresh you'll see that your email is hidden.
[Developer] [Pazza]: Your user level on the forums permit you to see emails even though they are marked hidden.
[DevTeam] [Astaldo]: Ah.. thanks for the clarification and apologies for "crying wolf" in that case :
[DevTeam] [Kaidenn]: PAZZA! i miss you.
[DevTeam] [Nachonut]: Lol, it's funny how it takes spam message reports to get me to come back
[DevTeam] [sylvanaar]: Check out the beta tester forum. Need alpha testers and feedback so I can come up with a maintenance plan.
[Developer] [Pazza]: loaded some new spam prevention modules... lets see if this stops the bastards.
[DevTeam] [Maziel]: Thought I'd check in and say Howdy Doody from Australia
[DevTeam] [Maziel]: Yeah the spam from shoes salesmen was becoming insane
[Guest] [Delakando]: What ever happened to the ability to track friend's location by wim? Other then just showing their general zone location.
Zeke pokes his head around the corner.
[DevTeam] [Zeke]: Anybody home?
[Guest] [Theillur]: I would like to know if it is just me.
[Guest] [Theillur]: http://www.wimaddon.com/forums/index.php/topic,1796.0.html
[Guest] [Nev]: I'm here
[Guest] [Nev]: I don't think anyone else is though
[Guest] [tomasio]: great site [url=http://freeonlinemusicvideos.net].[/url] [url=http://freepeopleclothing.org].[/url]
[Guest] [Theillur]: Nev it is not working for Zeke as well.
[DevTeam] [lothaer]: im here
[DevTeam] [lothaer]: ...
lothaer yawns sleepily.
[DevTeam] [lothaer]: sooooooooooooooooo
[Guest] [j3ff]: Hello. It is very quiet. I would love a response to my thread directly below your "Been very quiet" thread!
[DevTeam] [lothaer]: Check out my new post in the Skins forum
[DevTeam] [lothaer]: Posted a new download in the skins forum check it out
[DevTeam] [lothaer]: Zeke, Maziel, Pazza, Nachonut, sylvanaar, Kaidenn, Astaldo where are you?
[DevTeam] [lothaer]: It would be a real shame if WIM was left to die.
[DevTeam] [lothaer]: i think these forums are dead, Sylvanaar dosnt post on them as he only bug fixes when possible. WIMs future isnt very bright
[Guest] [justgiz]: Yea, its rather sad.
[Guest] [silvercola]: I wish it had skype
[DevTeam] [lothaer]: noy possible for a addon to do.
[DevTeam] [lothaer]: ...........
[Guest] [elzershark]: where is the download file?
lothaer beckons everyone over to you.
[DevTeam] [lothaer]: has anyone been able to take WIM to the beta yet?
[DevTeam] [lothaer]: PTR*
[DevTeam] [Maziel]: *sticks head up and looks around*
lothaer cries.
[DevTeam] [lothaer]: who the hell flagged my post as spam?
[Guest] [primalforce]: Hey guys
[DevTeam] [lothaer]: hello Primalforce.
[DevTeam] [lothaer]: PAZZA COME BACK!!!

[dracula]

Apparently in 2.2 the new method of hooking the chat editbox itself seems to work for more item addons, that's great to hear.

However, there are still addons that will not copy any link into WIM's editbox with shift+click, but work fine on the normal chat line, for example CharactersViewer.

Could you please provide a tiny fragment of code that shows how to implement an item link hook for incompatible addons? Thanks in advance!

[Pazza]

the best way... post them here and I'll try my best to take care of them for you. :-)

[dracula]

Well, so far I noticed problems with CharactersViewer, which I linked to in my first post. It uses rpg-CharacterProfiler to store the items (which is included in the package I believe)

I like that addon for viewing items on bank or alts, but also like link from it. Right now I have to perform all sort of tricks to be able to whisper the link

[kashan]

Hello ! First I wanna say thanks for the hard work on WIM ! It actually kicks ass!

Just to let you know that the item hooking system doesnt work ok with CONFAB. This addon wasnt updated for 9months or so and I won't use it anymore (may switch for prat2 or something). But I thought it would be nice to let people know it can be conflicting with WIM :-)

Keep it up!
John.

[Pazza]

Wow I am sorry dracula -- When I was scurrying to fix bugs I neglected to review this forum. I will look into CharacterViewer for you.

It is true however, the new "Universal Linking" system I came up with isn't exactly universal. And I will explain why briefly.

I don't recall when it was implemented (I think a long time ago lol) a new text function was added to text objects called Insert(text) -- for example

ChatEditBox:Insert(myLink_here);

WIM accounts for all instances of this... However there are other mods that try to replicate this same action by doing this:

ChatEditBox:SetText(ChatEditBox:GetText.." "..myLink_here);

WIM can not accomodate a call like this. Why? Well I can't control GetText() -- I can but then it taints the chat edit box and you can no longer call slash commands such as /tar. This is a BIG deal for most, therefore I am forced to handle Insert() calls only.

What does this mean? either I need to make a special hook for CharacterViewer or the author fixes his addon to follow the propper convention. I will not rely on that change to be made and will add my own hook. However, if at some point the author decides to update his addon, WIM will begin to receive double links most likely. If that happens, just report back here and I will reverse my changes. Hope that helps.

As far as CONFAB -- thanks for the FYI -- I do not have a known issues page on the site but perhaps I will add one. Thank you for your help guys/gals.

[dracula]

Thanks for the reply Pazza.

I had a look at CharactersViewer's code, and I found the following in the ItemButton:OnClick function:

Code:

if ( IsControlKeyDown() and not ignoreModifiers ) then
DressUpItemLink("item:"..link);
elseif ( IsShiftKeyDown() and not ignoreModifiers ) then
if ( ChatFrameEditBox:IsShown() ) then
ChatFrameEditBox:Insert(longlink);
else
-- PlaceHolder
end
else
-- PlaceHolder
end

It seems that it IS using the Insert function, but it explicitly checks whether the chatline is shown... I removed that check, and it works perfectly with WIM's chatline now, and has no side-effects when shift+clicking an item without any chatline active

I don't know if you can 'fake' a chatline being shown, so addons that check for it will insert their item anyway Or perhaps it's not worth bothering and should the check just never be made by the other addons.

[Pazza]

WIM actually cloaks/fakes IsVisible() which I thought was an alias of IsShown(). Since it isn't, I'll add IsShown() to my hacks as well.

Thanks for the info.

I hear patch day is tuesday. Unfortunately I have nothing updated since my last update. I hope I can squeeze in some time this weekend to at least handle most of the bugs that have been reported. (Although it seems that many are due to addon conflicts :-/).

[dracula]

WIM actually cloaks/fakes IsVisible() which I thought was an alias of IsShown(). Since it isn't, I'll add IsShown() to my hacks as well.

Aah, yeah, I ran into this myself when making a macro that toggles the shapeshift bar on and off.

According to wowwiki's API docs a frame can be shown, but still be invisible because one of its parents is hidden; in that case, IsShown()=true and IsVisible()=false.

[Pazza]

Thanks for verifying that. I'll update it.